Conversation
nefrathenrici
approved these changes
Oct 27, 2025
Member
nefrathenrici
left a comment
nefrathenrici
left a comment
There was a problem hiding this comment.
Thanks for catching this!
ext/checkers.jl
Outdated
Comment on lines
267
to
274
| positive_count = 0 | ||
| count = 0 | ||
| for val in var.data | ||
| isnan(val) && continue | ||
| count += 1 | ||
| positive_count += val > 0 | ||
| end | ||
| sim_pos_proportion = positive_count / count |
Member
There was a problem hiding this comment.
I think this could be simpler:
Suggested change
| positive_count = 0 | |
| count = 0 | |
| for val in var.data | |
| isnan(val) && continue | |
| count += 1 | |
| positive_count += val > 0 | |
| end | |
| sim_pos_proportion = positive_count / count | |
| valid = @. !isnan(var.data) | |
| sim_pos_proportion = sum((var.data .> 0) .& valid) / sum(valid) |
The original code is `nanmean(var.data .> 0)`. This does not work, because `NaN > 0` is `false` and not `NaN`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code is
nanmean(var.data .> 0). This does not work, becauseNaN > 0isfalseand notNaN.closes #254